feat(loader): Use relative path inside SDL#23
Open
leosuncin wants to merge 2 commits intoprisma-labs:masterfrom
Open
feat(loader): Use relative path inside SDL#23leosuncin wants to merge 2 commits intoprisma-labs:masterfrom
leosuncin wants to merge 2 commits intoprisma-labs:masterfrom
Conversation
Use the file path instead of file content to import schema. Set Jest's environment to node to avoid the error with jsdom's localStorage, see jestjs/jest#6766 and jsdom/jsdom#2304. BREAKING CHANGE: Use absolute path inside DSL won't work anymore, but now will be the same behavior of `graphql-import` dealing with paths. Fix prisma-labs#10
leosuncin
force-pushed
the
fix/relative-path-inside-sdl
branch
from
2ac1f60 to
a4662d0
Compare
Show directory tree and use relative paths in the example.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the file path instead of file content to import schema. Set Jest's environment to node
to avoid the error with jsdom's localStorage, see jestjs/jest#6766 and jsdom/jsdom#2304.
BREAKING CHANGE: Use absolute path inside DSL won't work anymore, but now will be the same
behavior of
graphql-importdealing with paths.Fix #10